CI: Detect IGC versions from installed drivers in G++ host workflow #560
+78
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonyvance
added
the
Tests
| if(OCL_DRIVER_VERSION MATCHES "^25\\.([0-9]+)") | ||
| set(DRIVER_MINOR ${CMAKE_MATCH_1}) | ||
|
|
||
| # Map driver version to IGC version (enforce minimum 2.18 for PVC compatibility) |
There was a problem hiding this comment.
It seems it would be quite a bit easier if we directly do add_compile_defintion of the minor, major of the Neo runtime version and then use that in the code to decide whether the test should be run. Sorry I should have suggested that in the first place. Up to you whether you still want to change this or keep this because it is already implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.