Skip to content

Conversation

@rishi-yadav
Copy link

@rishi-yadav rishi-yadav commented Oct 16, 2025

API Function Template Signature Function
XE_LOAD_2D <Bits, Height, Width> High-speed 2D block loading
XE_STORE_2D <Bits, Height, Width> Efficient 2D block storage

11 test cases added for diff datatypes with 7 variations of height so total 77 variations used in this PR

@rishi-yadav rishi-yadav marked this pull request as draft October 16, 2025 10:09
@rishi-yadav rishi-yadav changed the title Unit test cases for XE_LOAD_2D Unit test cases for XE LOAD and STORE Oct 16, 2025
@rishi-yadav rishi-yadav marked this pull request as ready for review October 16, 2025 10:29
@rishi-yadav
Copy link
Author

rishi-yadav commented Oct 16, 2025

With IGC >= 2.18

[----------] Global test environment tear-down
[==========] 71 tests from 4 test suites ran. (6890 ms total)
[  PASSED  ] 71 tests.

with IGC = 2.11
 TEMPORARY: Force lower version for testing
set(IGC_VER "2.11")  # Change this to test different versions

[----------] Global test environment tear-down
[==========] 42 tests from 4 test suites ran. (3453 ms total)
[  PASSED  ] 40 tests.
[  SKIPPED ] 2 tests, listed below:
[  SKIPPED ] PVC_CuTe_Xe.MMA_DPAS_SKIPPED
[  SKIPPED ] PVC_CuTe_Xe.XE_COPY_2D_SKIPPED

@Antonyvance Antonyvance requested a review from Copilot October 16, 2025 21:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for Intel XE architecture's 2D block copy operations, specifically testing the XE_LOAD_2D and XE_STORE_2D template functions. The tests validate functionality across multiple data types and block dimensions.

  • Added 84 test cases covering various data types (uint8_t, int8_t, uint16_t, int16_t, half_t, bfloat16_t, uint32_t, int32_t, float, tfloat32_t, char) with different height configurations (2-8 rows)
  • Implemented device kernel that performs load-to-register followed by store-to-memory operations to verify round-trip data integrity
  • Added fallback test cases for environments with insufficient IGC compiler version support

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test/unit/cute/intel_xe/xe_copy_2d_test.cpp New comprehensive test suite for XE_LOAD_2D and XE_STORE_2D operations with 84 test cases across multiple data types
test/unit/cute/intel_xe/mma.cpp Added fallback test case for environments lacking IGC 2.18+ support
test/unit/cute/intel_xe/CMakeLists.txt Integrated new test file into build system

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Antonyvance Antonyvance added the Tests For Unit tests and Benchmark tests and general validation specific changes label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests For Unit tests and Benchmark tests and general validation specific changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants