-
Notifications
You must be signed in to change notification settings - Fork 64
Unit test cases for XE LOAD and STORE #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive unit tests for Intel XE architecture's 2D block copy operations, specifically testing the XE_LOAD_2D and XE_STORE_2D template functions. The tests validate functionality across multiple data types and block dimensions.
- Added 84 test cases covering various data types (uint8_t, int8_t, uint16_t, int16_t, half_t, bfloat16_t, uint32_t, int32_t, float, tfloat32_t, char) with different height configurations (2-8 rows)
- Implemented device kernel that performs load-to-register followed by store-to-memory operations to verify round-trip data integrity
- Added fallback test cases for environments with insufficient IGC compiler version support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/unit/cute/intel_xe/xe_copy_2d_test.cpp | New comprehensive test suite for XE_LOAD_2D and XE_STORE_2D operations with 84 test cases across multiple data types |
| test/unit/cute/intel_xe/mma.cpp | Added fallback test case for environments lacking IGC 2.18+ support |
| test/unit/cute/intel_xe/CMakeLists.txt | Integrated new test file into build system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
XE_LOAD_2D<Bits, Height, Width>XE_STORE_2D<Bits, Height, Width>11 test cases added for diff datatypes with 7 variations of height so total 77 variations used in this PR