Fix build with GCC < 11: [[fallthrough]] is supported but not allowed in C #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in C
I think GCC says `__has_cpp_attribute(fallthrough)` is true because C++
supports it (it means "has C++ attribute"), but that doesn't apply to
the C language. This causes a compilation error:
```
compilersupport_p.h:57:41: error: expected expression before '[' token
57 | # define CBOR_FALLTHROUGH [[fallthrough]]
| ^
cborparser.c:225:13: note: in expansion of macro 'CBOR_FALLTHROUGH'
225 | CBOR_FALLTHROUGH;
| ^~~~~~~~~~~~~~~~
```
Instead, we should use the C23 `__has_c_attribute` to detect the C
attribute.
Fixes intel#293.
Signed-off-by: Thiago Macieira <[email protected]>
thiagomacieira
force-pushed
the
Fix_build_with_GCC_11_fallthrough_is_supported_but_not_allowed_in_C
branch
from
41acfa8 to
fe675e3
Compare
thiagomacieira
deleted the
Fix_build_with_GCC_11_fallthrough_is_supported_but_not_allowed_in_C
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think GCC says
__has_cpp_attribute(fallthrough)is true because C++ supports it (it means "has C++ attribute"), but that doesn't apply to the C language. This causes a compilation error:Instead, we should use the C23
__has_c_attributeto detect the C attribute.Fixes #293.