Skip to content

Disable mpi backend build when found xccl #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable mpi backend build when found xccl #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ if(USE_XCCL)
caffe2_update_option(USE_XCCL OFF)
caffe2_update_option(USE_C10D_XCCL OFF)
update_caffe2_macros_file()
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The else() clause is unclear without context. Consider adding a comment to explain that this branch executes when XCCL is found and enabled, to improve code readability.

Suggested change
update_caffe2_macros_file()
update_caffe2_macros_file()
# XCCL is found and enabled; disable MPI options and update macros file.

Copilot uses AI. Check for mistakes.

else()
caffe2_update_option(USE_MPI OFF)
caffe2_update_option(USE_C10D_MPI OFF)
update_caffe2_macros_file()
endif()
endif()

Expand Down
Loading