separate comm init from getXCClComm #2090
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR separates communication initialization logic from the communication retrieval process by splitting the getXCCLComm method into two distinct functions.
- Extracted communication lookup logic into a new
getXCCLCommmethod that only retrieves existing communicators - Created a new
initXCCLCommmethod that handles the initialization of new communicators - Updated call sites to first check for existing communicators before initializing new ones
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/xccl/ProcessGroupXCCL.hpp | Added method declaration for new getXCCLComm overload and initXCCLComm method |
| src/xccl/ProcessGroupXCCL.cpp | Implemented the separation of concerns by creating distinct lookup and initialization methods, updated call sites |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| op_id_++; | ||
| auto comm = getXCCLComm(key, device, opType, p2pRank, isSendRecvSelf); | ||
| std::shared_ptr<xcclComm_t> comm = getXCCLComm(key); |
There was a problem hiding this comment.
Seems like no difference with previous code, then why to separate as two APIs/steps?
There was a problem hiding this comment.
Just for align nccl, To facilitate future feature integration, we can first align this part.
dvrogozh
requested changes
Sep 30, 2025
Co-authored-by: Dmitry Rogozhkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.