Skip to content

Conversation

CuiYifeng
Copy link
Contributor

@CuiYifeng CuiYifeng commented Oct 9, 2025

Since more FP8 Ops will be supported on XPU recently, basic FP8 cases should be activated. This PR will remove the following cases from skip list:

TestCommonXPU::test_compare_cpu_torch__scaled_mm_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_out_torch__scaled_mm_xpu_float8_e4m3fn SKIPPED (Skipped!)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e4m3fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e5m2 SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e5m2fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e4m3fn PASSED
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e4m3fnuz PASSED
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e5m2 PASSED
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e5m2fnuz PASSED
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e4m3fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e5m2 SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e5m2fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e4m3fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e5m2 SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e5m2fnuz SKIPPED (test doesn't work on XPU backend)

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 08:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR activates FP8 (8-bit floating point) test cases for XPU backend by removing the global FP8 skip pattern from the test skip list. With FP8 support now available on XPU, the tests that were previously skipped due to lack of FP8 implementation can now be enabled.

Key changes:

  • Removes the "float8" skip pattern that was blocking all FP8-related tests
  • Removes associated comments explaining why FP8 was not supported
  • Enables previously skipped FP8 test cases including _scaled_mm and _refs_eye operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CuiYifeng
Copy link
Contributor Author

@daisyden Please activate these cases that do not work on XPU backend in stock Pytorch.

@dvrogozh
Copy link
Contributor

dvrogozh commented Oct 9, 2025

Since FP8 will be supported on XPU recently

@CuiYifeng : FP8 is already supported for the scope of activated tests. Or it will be supported soon? If the first, then we should expect FP8 tests to execute without failures. If the latter we should see test failures. I guess the first is true as I don't see FP8 specific test failures in the summary.

@CuiYifeng
Copy link
Contributor Author

Since FP8 will be supported on XPU recently

@CuiYifeng : FP8 is already supported for the scope of activated tests. Or it will be supported soon? If the first, then we should expect FP8 tests to execute without failures. If the latter we should see test failures. I guess the first is true as I don't see FP8 specific test failures in the summary.

@dvrogozh Thanks for the reminder. The first interpretation is closer to the facts. I have updated "FP8 will be supported" to "more FP8 Ops will be supported".

@CuiYifeng CuiYifeng force-pushed the yifeng/activate_fp8_ut branch 2 times, most recently from 4265674 to 2c1dddd Compare October 15, 2025 01:13
@CuiYifeng CuiYifeng force-pushed the yifeng/activate_fp8_ut branch from 2c1dddd to 07ffc3e Compare October 16, 2025 02:00
@CuiYifeng CuiYifeng added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 5b9b8d2 Oct 16, 2025
25 checks passed
@CuiYifeng CuiYifeng deleted the yifeng/activate_fp8_ut branch October 16, 2025 06:02
mengfei25 pushed a commit that referenced this pull request Oct 16, 2025
Since more FP8 Ops will be supported on XPU recently, basic FP8 cases
should be activated. This PR will remove the following cases from skip
list:
```
TestCommonXPU::test_compare_cpu_torch__scaled_mm_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_out_torch__scaled_mm_xpu_float8_e4m3fn SKIPPED (Skipped!)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e4m3fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e5m2 SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref__refs_eye_xpu_float8_e5m2fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e4m3fn PASSED
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e4m3fnuz PASSED
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e5m2 PASSED
TestCommonXPU::test_python_ref_executor__refs_eye_executor_aten_xpu_float8_e5m2fnuz PASSED
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e4m3fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e5m2 SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_meta__refs_eye_xpu_float8_e5m2fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e4m3fn SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e4m3fnuz SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e5m2 SKIPPED (test doesn't work on XPU backend)
TestCommonXPU::test_python_ref_torch_fallback__refs_eye_xpu_float8_e5m2fnuz SKIPPED (test doesn't work on XPU backend)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants