-
Notifications
You must be signed in to change notification settings - Fork 60
add time event support #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add time event support #2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds time event support to the XCCL (XPU Collective Communication Library) system by introducing event caching and timing capabilities. The changes enable performance measurement and event management for XPU operations through a caching mechanism.
Key changes:
- Introduces
XPUEventCache
class for efficient event object reuse and timing support - Adds timing functionality to
WorkXCCL
with start/end events and duration calculation - Updates point-to-point communication operations to support timing and preprocessing/postprocessing hooks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
src/xccl/XPUEventCache.hpp | Defines the XPUEventCache class interface for managing cached XPU events |
src/xccl/XPUEventCache.cpp | Implements event caching logic with timing support and thread-local device mapping |
src/xccl/ProcessGroupXCCL.hpp | Adds timing support fields and template method overloads for point-to-point operations |
src/xccl/ProcessGroupXCCL.cpp | Integrates event caching, timing functionality, and refactors point-to-point operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
// new one. | ||
if (!events.empty()) { | ||
event = events.front(); | ||
events.pop_front(); |
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider checking if the cached event is still valid or resetting its state before reusing it, as events may retain previous state that could affect timing accuracy.
events.pop_front(); | |
events.pop_front(); | |
// Reset the event's state before reuse | |
event->reset(); |
Copilot uses AI. Check for mistakes.
Usage