Eliminate the boring warning if no AOT enabled #2180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FP64 conversion emulation flag handling to eliminate unnecessary warnings when AOT (Ahead-of-Time) compilation is not enabled. Instead of unconditionally warning when the -fsycl-fp64-conv-emu flag is unsupported, the warning is now only shown when the flag is actually needed. The flag is now conditionally applied only when building for specific targets (DG2/ATS-M) that require FP64 emulation.
Key Changes:
- Move FP64 conversion emulation flag from global to target-specific application
- Show unsupported flag warning only when the flag would have been used
- Apply
-fsycl-fp64-conv-emuconditionally based on AOT target architecture
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
guangyey
force-pushed
the
guangyey/fix
branch
from
fc80688 to
6d57227
Compare
guangyey
requested review from
CuiYifeng,
EikanWang,
chuanqi129 and
chunhuanMeng
EikanWang
approved these changes
Oct 15, 2025
mengfei25
pushed a commit
that referenced
this pull request
Oct 16, 2025
# Motivation I would like to clarify that, according to the [FP64 Partial Emulation Proposal](https://intel.sharepoint.com/:w:/s/MLTSHdGPU/EaroFZY371hOqNL9182g2_EBOe83qGYTriAavPB6WTWXYg?e=XSRnKt), the SYCL compiler and IGC only perform FP64 conversion on the DG2 and ATS-M architectures, and this is only available when AOT is enabled. If AOT is not enabled, many warnings like the following will be emitted: ```bash icx: warning: '-fsycl-fp64-conv-emu' option is supported only for AOT compilation of Intel GPUs. It will be ignored for other targets ``` To avoid these warnings, the `-fsycl-fp64-conv-emu` flag should only be added when AOT is enabled for the specific target architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I would like to clarify that, according to the FP64 Partial Emulation Proposal, the SYCL compiler and IGC only perform FP64 conversion on the DG2 and ATS-M architectures, and this is only available when AOT is enabled.
If AOT is not enabled, many warnings like the following will be emitted:
To avoid these warnings, the
-fsycl-fp64-conv-emuflag should only be added when AOT is enabled for the specific target architectures.