Skip to content

Conversation

Shifna12Zarnaz
Copy link

No description provided.

@gitguardian
Copy link

gitguardian bot commented Aug 1, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 6a42a5b charts/agent/values.yaml View secret
- Generic High Entropy Secret 6a42a5b charts/agent/values.yaml View secret
- Generic High Entropy Secret 6a42a5b charts/client/values.yaml View secret
- Generic High Entropy Secret 6a42a5b charts/client/values.yaml View secret
- Generic High Entropy Secret 42c0439 charts/agent/values.yaml View secret
- Generic High Entropy Secret 42c0439 charts/agent/values.yaml View secret
- Generic High Entropy Secret 42c0439 charts/client/values.yaml View secret
- Generic High Entropy Secret 42c0439 charts/client/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message that will be displayed on users' first pull request

value: {{ .Values.nats.credidentifier | quote }}
- name: NATS_ENTITY_NAME
value: {{ .Values.nats.entityname | quote }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be conditional wise eg .Values.vault.enabled true then only we should inject these values

- name: NATS_TOKEN
value: {{ .Values.nats.auth.token }}
# - name: NATS_TOKEN
# value: {{ .Values.nats.auth.token }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these also same way, incase vault integration not enabled then we need to inject this variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants