Skip to content

Fix: Logout multiple messages issue. Closes #2716#2741

Closed
Hverma1206 wants to merge 1 commit intointelowlproject:developfrom
Hverma1206:frontend-test
Closed

Fix: Logout multiple messages issue. Closes #2716#2741
Hverma1206 wants to merge 1 commit intointelowlproject:developfrom
Hverma1206:frontend-test

Conversation

@Hverma1206
Copy link

Description

This PR fixes the issue where multiple logout messages were displayed instead of a single message when a user logs out.
Now, the logout event properly triggers only one message as expected.

Fixes Issue: Closes #2716

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ ]

After Fix:

image

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated. A link to the PR to the docs repo has been added as a comment here.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration). A link to the PR to the docs repo has been added as a comment here.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require any API key), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
    • If the plugin interacts with an external service, I have created an attribute called precisely url that contains this information. This is required for Health Checks.
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have added that raw JSON sample to the MockUpResponse of the _monkeypatch() method. This serves us to provide a valid sample for testing.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@drosetti
Copy link
Contributor

Move the target branch from master to develop

@Hverma1206 Hverma1206 changed the base branch from master to develop February 17, 2025 15:47
@Hverma1206
Copy link
Author

Done. I have moved the branch from master to develop

@drosetti
Copy link
Contributor

OK thanks, use the review feature of Github (top right), in this way I will be notified when you work is completed. Also complete correctly the checklist

@Hverma1206
Copy link
Author

Alright!

@github-actions
Copy link

This pull request has been marked as stale because it has had no activity for 10 days. If you are still working on this, please provide some updates or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 28, 2025
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

This pull request has been closed because it had no updates in 15 days. If you're still working on this fell free to reopen.

@github-actions github-actions bot closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logout multiple messages

2 participants