Optimized UserEvent.decay to resolve N+1 queries. #3506
Open
ayushgupta704 wants to merge 1 commit intointelowlproject:developfrom
Open
Optimized UserEvent.decay to resolve N+1 queries. #3506ayushgupta704 wants to merge 1 commit intointelowlproject:developfrom
ayushgupta704 wants to merge 1 commit intointelowlproject:developfrom
Conversation
276828f to
d0ddef5
Compare
Author
|
Hey @mlodic, I've updated this PR to be a single clean commit on top of the latest develop.
hopefully, this helps keep things running smoothly as the platform scales! Let me know if you have any feedback or if you'd like me to adjust the implementation Ready for review Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR resolves the scalability bottleneck in UserEventQuerySet.decay(). Previously, the decay process followed a 3N+1 query pattern, triggering sequential database round-trips for every event in the loop (fetching the DataModel, updating its reliability, and saving the UserEvent).
For a batch of 100 events, this resulted in 301 database queries. With this optimization, the same workload now takes only 6 queries O(1) constant time).
Key Architectural Changes:
relationship to collapse
once per batch with its final reliability score.
inconsistent states during partial failures.
Type of change
Checklist
(https://intelowlproject.github.io/docs/IntelOwl/contribute/) to this project