Skip to content

[Bug] Support all JA4_DB JAX fingerprint types and store them in DB. Closes #3541#3568

Open
chauhan-varun wants to merge 2 commits intointelowlproject:developfrom
chauhan-varun:fix/ja4-db-jax-model-storage
Open

[Bug] Support all JA4_DB JAX fingerprint types and store them in DB. Closes #3541#3568
chauhan-varun wants to merge 2 commits intointelowlproject:developfrom
chauhan-varun:fix/ja4-db-jax-model-storage

Conversation

@chauhan-varun
Copy link
Copy Markdown

@chauhan-varun chauhan-varun commented Mar 27, 2026

Description

This PR fixes #3541.

The existing JA4_DB analyzer was still tied to the old JSON-file cache and only handled the traditional JA4 lookup flow well. This change moves that storage into the database and expands the analyzer so it can work with all JAX fingerprint types currently returned by JA4DB, including ja4s, ja4h, ja4x, ja4t, ja4ts, and ja4tscan.

I added a new Ja4DBEntry model plus the related migration, updated the analyzer to populate and query that table, and removed the dependency on ja4_db.json for runtime lookups. I also added test coverage for the updater path, several JAX lookup paths, duplicate match handling, and update failure handling.

image image
{
  "report": {
    "os": null,
    "notes": "",
    "device": null,
    "library": null,
    "verified": true,
    "application": "Nmap",
    "ja4_fingerprint": null,
    "ja4h_fingerprint": null,
    "ja4s_fingerprint": null,
    "ja4t_fingerprint": "1024_2_1460_00",
    "ja4x_fingerprint": null,
    "ja4ts_fingerprint": null,
    "observation_count": 1,
    "user_agent_string": null,
    "ja4tscan_fingerprint": null,
    "certificate_authority": null,
    "ja4_fingerprint_string": null
  },
  "data_model": null,
  "errors": [],
  "parameters": {}
}

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated. A link to the PR to the docs repo has been added as a comment here.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration). A link to the PR to the docs repo has been added as a comment here.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require any API key), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
    • If the plugin interacts with an external service, I have created an attribute called precisely url that contains this information. This is required for Health Checks (HEAD HTTP requests).
    • If a new analyzer has beed added, I have created a unittest for it in the appropriate dir. I have also mocked all the external calls, so that no real calls are being made while testing.
    • I have added that raw JSON sample to the get_mocker_response() method of the unittest class. This serves us to provide a valid sample for testing.
    • I have created the corresponding DataModel for the new analyzer following the documentation
  • I have inserted the copyright banner at the start of the file: # This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.
  • Please avoid adding new libraries as requirements whenever it is possible. Use new libraries only if strictly needed to solve the issue you are working for. In case of doubt, ask a maintainer permission to use a specific library.
  • If external libraries/packages with restrictive licenses were added, they were added in the Legal Notice section.
  • Linters (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

@chauhan-varun
Copy link
Copy Markdown
Author

Hi @mlodic, this is ready for review Could you please take a look?

@mlodic
Copy link
Copy Markdown
Member

mlodic commented Mar 27, 2026

it's not there are no screenshots or JSON results

@chauhan-varun
Copy link
Copy Markdown
Author

chauhan-varun commented Mar 28, 2026

I’ve updated the PR description and added both the screenshot and the raw JSON from a finished JA4_DB analysis, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants