Skip to content

Conversation

@kendepelchin
Copy link
Contributor

@kendepelchin kendepelchin commented Apr 24, 2025

I started implementing intercom in a react-native project and when I looked at the types for loginUserWithUserAttributes I saw that i could pass the following:

export type UserAttributes = {
  companies?: Company[];
  customAttributes?: CustomAttributes;
  email?: string;
  languageOverride?: string;
  name?: string;
  phone?: string;
  signedUpAt?: number;
  unsubscribedFromEmails?: boolean;
  userId?: string;
};

This didn't seem to work, as I needed to login first, and update the user after. All data I passed to this function was ignored (besides email & userId).
If I look at the native implementation I can see that only email & userId can be provided to the loginUserWithUserAttributes function.

If I missed anything, feel free to guide me towards the proper implementation.

Thanks for making this open source 🙏

@kendepelchin kendepelchin changed the base branch from main to dev April 28, 2025 10:00
@kendepelchin kendepelchin changed the base branch from dev to main April 28, 2025 10:00
@pavlos-sqds
Copy link

OMG please merge this. I had the same issue, and turns out the types are wrong and misleading. I came here to make the exact same PR. happy this exists already.

@kendepelchin
Copy link
Contributor Author

kendepelchin commented Jul 23, 2025

OMG please merge this. I had the same issue, and turns out the types are wrong and misleading. I came here to make the exact same PR. happy this exists already.

@pavlos-sqds I've changed it using patch-package.

@jasonpraful jasonpraful merged commit 8e5ba12 into intercom:main Aug 28, 2025
8 checks passed
@kendepelchin kendepelchin deleted the task/update-types branch September 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants