fix: RSpec one-liner example descriptions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSpec one-liner examples (e.g., `it { is_expected.not_to be_nil }`)
generate descriptions after execution. Updated formatter to capture
the final description in `example_finished` instead of relying on
the incomplete description at `example_started`.
americodls
changed the title
IslaHoe
approved these changes
Oct 2, 2025
americodls
added a commit
that referenced
this pull request
Oct 8, 2025
## Why?
Span names and full descriptions for RSpec one-liner syntax (like `it {
is_expected.not_to be_nil }`) were incorrectly showing file locations
instead of the matcher-generated descriptions. This made tracing output
less useful for tests using the concise one-liner syntax.
## How?
RSpec generates descriptions for one-liner examples after execution,
when the matcher runs. The formatter was capturing `description` and
`full_description` at `example_started` time, before these values were
populated.
The fix updates both the span name and `full_description` attribute in
the `example_finished` callback, after RSpec has generated the proper
description from the matcher. This ensures accurate span names and
descriptions for both one-liner and traditional examples.
We need to point Intercom's Gemfile to this repo so that we get those
updates without waiting for the upstream repo to accept them.
---
**Note:** Upstream PR created at
open-telemetry#1712
americodls
added a commit
that referenced
this pull request
Oct 12, 2025
## Why?
Span names and full descriptions for RSpec one-liner syntax (like `it {
is_expected.not_to be_nil }`) were incorrectly showing file locations
instead of the matcher-generated descriptions. This made tracing output
less useful for tests using the concise one-liner syntax.
## How?
RSpec generates descriptions for one-liner examples after execution,
when the matcher runs. The formatter was capturing `description` and
`full_description` at `example_started` time, before these values were
populated.
The fix updates both the span name and `full_description` attribute in
the `example_finished` callback, after RSpec has generated the proper
description from the matcher. This ensures accurate span names and
descriptions for both one-liner and traditional examples.
We need to point Intercom's Gemfile to this repo so that we get those
updates without waiting for the upstream repo to accept them.
---
**Note:** Upstream PR created at
open-telemetry#1712
americodls
added a commit
that referenced
this pull request
Oct 14, 2025
## Why?
Span names and full descriptions for RSpec one-liner syntax (like `it {
is_expected.not_to be_nil }`) were incorrectly showing file locations
instead of the matcher-generated descriptions. This made tracing output
less useful for tests using the concise one-liner syntax.
## How?
RSpec generates descriptions for one-liner examples after execution,
when the matcher runs. The formatter was capturing `description` and
`full_description` at `example_started` time, before these values were
populated.
The fix updates both the span name and `full_description` attribute in
the `example_finished` callback, after RSpec has generated the proper
description from the matcher. This ensures accurate span names and
descriptions for both one-liner and traditional examples.
We need to point Intercom's Gemfile to this repo so that we get those
updates without waiting for the upstream repo to accept them.
---
**Note:** Upstream PR created at
open-telemetry#1712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Span names and full descriptions for RSpec one-liner syntax (like
it { is_expected.not_to be_nil }) were incorrectly showing file locations instead of the matcher-generated descriptions. This made tracing output less useful for tests using the concise one-liner syntax.How?
RSpec generates descriptions for one-liner examples after execution, when the matcher runs. The formatter was capturing
descriptionandfull_descriptionatexample_startedtime, before these values were populated.The fix updates both the span name and
full_descriptionattribute in theexample_finishedcallback, after RSpec has generated the proper description from the matcher. This ensures accurate span names and descriptions for both one-liner and traditional examples.We need to point Intercom's Gemfile to this repo so that we get those updates without waiting for the upstream repo to accept them.
Note: Upstream PR created at open-telemetry#1712