Skip to content

Fix Duplicate track event sent to Singular #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remstos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Duplicate track event sent to Singular #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions Sources/analytics-swift-singular/SegmentSingular.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,17 @@ public class SingularDestination: DestinationPlugin, iOSLifecycle {
}

public func track(event: TrackEvent) -> TrackEvent? {
if let properties = event.properties?.dictionaryValue as? [String: Any], let revenue = extractRevenue(properties, key: "revenue") {
let currency = properties["currency"] as? String
analytics?.log(message: "Singular track revenue \(revenue)")
Singular.customRevenue(event.event, currency: currency, amount: revenue)
} else {
Singular.event(event.event)
}
// We don't need to edit the event or add any custom event
// The Segment event is properly propagated to Singular and
// marked as Revenue Event when needed.

// if let properties = event.properties?.dictionaryValue as? [String: Any], let revenue = extractRevenue(properties, key: "revenue") {
// let currency = properties["currency"] as? String
// analytics?.log(message: "Singular track revenue \(revenue)")
// Singular.customRevenue(event.event, currency: currency, amount: revenue, withAttributes: properties)
// } else {
// Singular.event(event.event)
// }
return event
}

Expand Down