Skip to content

ci: trigger another test #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosbaber merged 2 commits into from
Feb 20, 2026
Merged

ci: trigger another test #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
206cc3b
ci: trigger another test
bosbaber Feb 20, 2026
8a54daa
ci: trigger another test
bosbaber Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/staging-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,11 @@ jobs:
sudo systemctl status strapi.service

sync-mdx-to-strapi:
needs: check-pr-merge
needs: [check-pr-merge, rebuild-strapi]
if: |
(needs.check-pr-merge.outputs.is_merged_pr == 'true' && needs.check-pr-merge.outputs.content_changed == 'true') ||
needs.check-pr-merge.outputs.is_merged_pr == 'manual'
always() &&
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The always() condition combined with the rebuild-strapi dependency could cause the sync job to run even when rebuild-strapi fails. This means MDX content could be synced to a broken Strapi instance.

Consider using a more specific condition that checks if rebuild-strapi either succeeded or was skipped (not failed):

needs.rebuild-strapi.result == 'success' || needs.rebuild-strapi.result == 'skipped'

This would ensure the sync job only runs when Strapi is in a good state, while still allowing it to run when the rebuild was skipped (because no CMS changes were detected).

Suggested change
always() &&
(needs.rebuild-strapi.result == 'success' || needs.rebuild-strapi.result == 'skipped') &&

Copilot uses AI. Check for mistakes.
((needs.check-pr-merge.outputs.is_merged_pr == 'true' && needs.check-pr-merge.outputs.content_changed == 'true') ||
needs.check-pr-merge.outputs.is_merged_pr == 'manual')
runs-on: ubuntu-latest

steps:
Expand All @@ -156,8 +157,7 @@ jobs:
with:
version: 9

- name: Install CMS dependencies
working-directory: cms
- name: Install dependencies
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving pnpm install from cms/ directory to root directory changes where dependencies are installed. With the new pnpm workspace configuration, running pnpm install in the root will install dependencies for both the root package and the cms workspace package. However, the subsequent step still runs pnpm run sync:mdx in the cms working directory, which expects cms dependencies to be available.

This should work correctly with the workspace setup, but it's worth noting that this is a behavioral change: previously only CMS dependencies were installed, now all workspace dependencies are installed. This could increase build time and may not be necessary if the sync script only needs cms dependencies.

Suggested change
- name: Install dependencies
- name: Install CMS dependencies
working-directory: cms

Copilot uses AI. Check for mistakes.
run: pnpm install

- name: Sync MDX to Strapi
Expand Down
3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
packages:
- 'cms'

onlyBuiltDependencies:
- '@parcel/watcher'
- esbuild
Expand Down