Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix merge detection in the staging merge GitHub Actions workflow for the interledger.org site/CMS automation, while also adjusting workspace configuration and making a couple of small content/docs edits.
Changes:
- Improve merged-PR detection logic in
.github/workflows/staging-merge.ymland adjust job dependencies/install step. - Add
cmstopnpm-workspace.yamlsopnpm installcan install workspace dependencies from the repo root. - Minor edits to CMS README revision marker and a single blog copy tweak.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/content/blog/2026-01-29-interledger-foundation-awards-200000-social-web-foundation-support-decentralized-social-media.mdx |
Minor copy edit in blog post body text. |
pnpm-workspace.yaml |
Declares cms as a pnpm workspace package to support root-level installs. |
cms/README.md |
Updates the “Last updated / Revision” comment. |
.github/workflows/staging-merge.yml |
Enhances merge detection and adjusts sync-mdx-to-strapi dependencies + install step. |
Comments suppressed due to low confidence (3)
.github/workflows/staging-merge.yml:155
sync-mdx-to-strapiusesalways()while also depending onrebuild-strapi. Ifrebuild-strapiruns and fails, this job can still run and attempt to sync against a potentially broken/half-updated Strapi instance. Consider adding an explicit guard onneeds.rebuild-strapi.result(e.g., allowsuccess/skipped, blockfailure/cancelled) so sync only runs when the rebuild didn’t fail.
needs: [check-pr-merge, rebuild-strapi]
if: |
always() &&
((needs.check-pr-merge.outputs.is_merged_pr == 'true' && needs.check-pr-merge.outputs.content_changed == 'true') ||
needs.check-pr-merge.outputs.is_merged_pr == 'manual')
.github/workflows/staging-merge.yml:56
isMergeCommitis assigned the result of.match(...)(array/null) but is later used as a boolean. This works, but the name is misleading and makes the logic easy to misread/extend incorrectly. Consider switching to a boolean check (e.g.,.test(...)orBoolean(match)) or renaming the variable to reflect that it’s a match object.
const isMergeCommit = commit.commit.message.match(/^Merge pull request #(\d+)/)
src/content/blog/2026-01-29-interledger-foundation-awards-200000-social-web-foundation-support-decentralized-social-media.mdx:16
- This PR is titled as a merge-detection fix, but this change is an unrelated copy edit in a blog post. Consider reverting this change or moving it to a separate PR to keep the workflow fix isolated and easier to audit/roll back.
For creators, publishers, and community-run platforms, building a sustainable future on the web has become increasingly difficult. Advertising revenues continue to decline, audiences are experiencing subscription fatigue, and smaller publishers are often left choosing between paywalls, platform dependence, or just giving content away for free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.