Open
Conversation
Add tests fix some warning fix some warnings fix build update gitignore
cozminu
requested review from
golobitch and
koekiebox
and removed request for
koekiebox
koekiebox
requested changes
Feb 25, 2026
koekiebox
left a comment
koekiebox
left a comment
There was a problem hiding this comment.
Mostly minor issues. Once looked at, I will 👁️ again.
| return GenerateKey(generateKeyArgs); | ||
| } | ||
| } No newline at end of file | ||
| } No newline at end of file |
| public Task<OutgoingPaymentResponse> CreateOutgoingPaymentAsync(AuthRequestArgs requestArgs, | ||
| OutgoingPaymentBody body, | ||
| CancellationToken cancellationToken = default); | ||
| } No newline at end of file |
| response.Dispose(); | ||
| } | ||
| } | ||
| } No newline at end of file |
|
|
||
| public async Task<ListIncomingPaymentsResponse> ListIncomingPaymentsAsync(string walletAddress) | ||
| { | ||
| var waDetails = await client.GetWalletAddressAsync("https://ilp.interledger-test.dev/cozmin"); |
There was a problem hiding this comment.
Maybe read this from a property? Exposing your personal PP/wallet?
| } | ||
|
|
||
| return list; | ||
| } |
|
|
||
|
|
||
| var config = new CommandLineConfiguration(rootCommand); | ||
| return await config.InvokeAsync(args); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5