Conversation
Deployment results
Logs #19632903256 |
Member
Author
|
something errors. looking 👀 |
sidvishnoi
reviewed
Oct 24, 2025
sidvishnoi
reviewed
Nov 24, 2025
Comment on lines
+7
to
+8
| import { zValidator } from '@hono/zod-validator' | ||
| import z from 'zod' |
Member
There was a problem hiding this comment.
Nit: any reason we are moving these imports?
Member
Author
There was a problem hiding this comment.
Just for aesthetic reasons. To keep all the Zod imports at the end
Member
There was a problem hiding this comment.
Ok with me, but two points to consider:
- Consider not adding unnecessary changes to PRs. Send them separately if you'd like them.
- I personally prefer imports in this order:
npm packages (sorted either alphabetically; or in a manner of importance - boilerplate vs special imports for current file) local named packages (like `@shared/*`) local files
Member
Author
There was a problem hiding this comment.
ok with using this pattern for imports moving forward, in a separate pr.
We can use the external package eslint-plugin-import for this, as the vscode organizeImports setting is limited for grouping imports.
cc @kjmitchelljr
sidvishnoi
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes
Migration guide: https://zod.dev/v4/changelog