Skip to content

feat: support MMAON wallet #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: support MMAON wallet #1034

wants to merge 16 commits into from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 28, 2025 •
edited
Loading

Context

Closes #1029

Changes proposed in this pull request

  • MMAON uses GateHub wallet addresses behind the scenes, but with a proxy on own domain.
  • Add keyAutoAdd script for MMAON
  • Add E2E tests and setup CI to support that

Follow up: #1050 (right now, we don't test full connect as we can't yet - upstream issue).

@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script area: ci Improvements or additions to repository workflows area: tests Improvements or additions to tests area: shared Changes to shared libraries and utilities labels Apr 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025 •
edited
Loading

Extension builds preview

Name Link
Latest commit 264233e
Latest job logs Run #16723043337
Chrome (1005.62KB)Download
Firefox (1005.64KB)Download
Safari (1.93MB)Download

@github-actions github-actions bot removed the area: shared Changes to shared libraries and utilities label May 5, 2025
sidvishnoi

This comment was marked as duplicate.

Sign in to view

sidvishnoi
sidvishnoi commented May 9, 2025
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e
(had wrong config (wrong CI variable name) in GitHub env)

@sidvishnoi sidvishnoi marked this pull request as ready for review May 9, 2025 11:02
@sidvishnoi sidvishnoi requested a review from DarianM May 9, 2025 11:02
sidvishnoi
sidvishnoi commented May 9, 2025
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e
Passing locally lol.

@sidvishnoi
Copy link
Member Author

This explains why tests failing 😆🤦🏽

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianM DarianM Awaiting requested review from DarianM

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: ci Improvements or additions to repository workflows area: content Improvements or additions to extension content script area: tests Improvements or additions to tests blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MMAON as wallet
1 participant
@sidvishnoi