feat: store lexicons in db #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With settings optimized for JSON usage
… in ingest route Add type guards and event interfaces to distinguish between 'user' and 'record' events from Nexus. Only 'record' events are processed; 'user' events are ignored as per current requirements. Improves type safety and prevents unwanted processing of irrelevant events.
…t route - Expand the RecordEvent type with detailed record fields for better type safety - Add ackEvent and retryEvent helpers for consistent Nexus event responses - Refactor POST handler to use new helpers and always acknowledge events - Improve error handling to prevent retry loops
…nsid - Add db and lexicons schema imports - Expand RecordEvent type to type record with id/nsid - Upsert lexicon records into db on record events - Log ingested events with id, nsid, cid, and action
BinaryFiddler
approved these changes
Nov 26, 2025
BinaryFiddler
left a comment
BinaryFiddler
left a comment
There was a problem hiding this comment.
Looks good, just one question about postgres as I just ran into this in a separate project when upgrading from postgres 17 to 18
| - NEXUS_LOG_LEVEL=info | ||
|
|
||
| postgres: | ||
| image: postgres:17-alpine |
There was a problem hiding this comment.
nit: Do we want to use 18 which is the current version and has some performance improvement?
In subsequent versions of postgres the mount directory is changed to: /var/lib/postgresql, https://github.com/docker-library/docs/blob/master/postgres/README.md#pgdata, potentially save some debugging down the line should people upgrade the db version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary