generated from internet-development/nextjs-sass-starter
-
Notifications
You must be signed in to change notification settings - Fork 11
ci: fix release artifacts and optimize build workflows #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f6724c
to
d26118c
Compare
Only run build workflow when pull requests target the main branch, preventing unnecessary builds on feature branch pushes.
Change tag pattern to require v prefix (e.g., v1.0.0) following semantic versioning conventions.
Update release workflow to zip fonts from public/fonts directory where they were moved, fixing missing artifacts in releases.
- Rename fonts.zip to ServerMono-fonts.zip for clarity - Add artifactErrorsFailBuild to catch upload failures - Include individual font files as artifacts
Update checkout action from v3 to v4 to address actionlint warnings and ensure compatibility.
Replace npm install with npm ci for faster, more reliable builds with reproducible dependency installation.
Enable npm ci in CI/CD workflows by committing package-lock.json. This ensures consistent dependency versions across environments and faster, more reliable builds.
d26118c
to
19d2efe
Compare
jimmylee
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caidanw
added a commit
that referenced
this pull request
Jun 10, 2025
* ci: restrict build workflow to PRs targeting main Only run build workflow when pull requests target the main branch, preventing unnecessary builds on feature branch pushes. * ci: update release trigger to semantic version pattern Change tag pattern to require v prefix (e.g., v1.0.0) following semantic versioning conventions. * fix: correct fonts directory path in release workflow Update release workflow to zip fonts from public/fonts directory where they were moved, fixing missing artifacts in releases. * ci: rename release artifact and add error handling - Rename fonts.zip to ServerMono-fonts.zip for clarity - Add artifactErrorsFailBuild to catch upload failures - Include individual font files as artifacts * ci: update GitHub Actions to latest versions Update checkout action from v3 to v4 to address actionlint warnings and ensure compatibility. * ci: use npm ci in build workflow Replace npm install with npm ci for faster, more reliable builds with reproducible dependency installation. * build: track package-lock.json for reproducible builds Enable npm ci in CI/CD workflows by committing package-lock.json. This ensures consistent dependency versions across environments and faster, more reliable builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
public/fonts
instead of the previousfonts
directorynpm ci
and updated action versionsDetails
The release workflow was failing to create the fonts.zip artifact because the font files were moved from
/fonts
to/public/fonts
but the workflow wasn't updated. This PR fixes that issue and makes several other improvements:Release workflow fixes:
public/fonts
ServerMono-fonts.zip
for clarityBuild workflow improvements:
npm ci
instead ofnpm install
for faster, reproducible buildsGeneral improvements: