Skip to content

Conversation

caidanw
Copy link
Contributor

@caidanw caidanw commented Jul 11, 2025

Summary

This pull request includes updates to the fonts/ServerMono.glyphs file to adjust font metric values for improved vertical alignment and spacing. As well as switching to the more intentional name Oblique instead of Slanted (was causing some problems with certain tools).

Font metric adjustments:

  • hheaAscender, typoAscender, and winAscent values were increased from 750 to 900 to provide more vertical space above the baseline.
  • hheaDescender, typoDescender, and winDescent values were adjusted from -250 to -200 to reduce the vertical space below the baseline.

Visuals

Before:
image

After:
image

It's a subtle change, but it does make a big impact on legibility and getting it aligned with the rest of the design. This also fixes the visual bug when patching with Nerd Fonts, where the icons and the letters were not aligned correctly.

@caidanw caidanw requested review from Copilot and jimmylee July 11, 2025 11:09
Copilot

This comment was marked as outdated.

Per the spec, it should be positive instead of a negative number like
the others.
@caidanw caidanw requested a review from Copilot July 11, 2025 19:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ServerMono font metrics to improve vertical alignment and spacing.

  • Increased hhea, typo, and win ascender values.
  • Reduced hhea and typo descender values and decreased win descent.
  • Updated a guide position and refined the glyph list.
Comments suppressed due to low confidence (1)

fonts/ServerMono.glyphs:19

  • The '◂' glyph has been removed from the glyph list; confirm if this removal is intentional. If this symbol is still needed for proper rendering, please restore it.
"/.notdef ▂▃▄▅▆▇█▀▔▏▎▍▌▋▊▉▐▕▖▗▘▙▚▛▜▝▞▟░▒▓●○◦◊■□▲▶▼◀▴▾◂╦╗╔═╩╝╚║╬╣╠╥╖╓┰┒┧┎┟╁┯┑┩┍┡╇╤╕╒╍╏╻┳┓┏━╸╾┉┋╺┅┇╹┻┛╿┗┃╋┫┣╅┭┵┽┲┺╊╃╮╭╯╰╌╎╳╲╱╷┬┐┌─╴╼┈┊╶┄┆╵╽┴┘└│┼┤├╆┮┶┾┱┹╉╄╨╜╙╀┸┦┚┞┖╈┷┪┙┢┕╧╛╘╫╢╟╂┨┠┿┥┝╪╡╞",

@caidanw caidanw changed the title fix: font metrics for better vertical alignment fix: font metrics for better vertical alignment and change Slanted to Oblique Jul 11, 2025
@caidanw caidanw merged commit 7c9312e into main Jul 11, 2025
1 check passed
@caidanw caidanw deleted the caidanw/fix-font-metrics branch July 11, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant