fix: font metrics for better vertical alignment and change Slanted to Oblique #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the spec, it should be positive instead of a negative number like the others.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ServerMono font metrics to improve vertical alignment and spacing.
- Increased hhea, typo, and win ascender values.
- Reduced hhea and typo descender values and decreased win descent.
- Updated a guide position and refined the glyph list.
Comments suppressed due to low confidence (1)
fonts/ServerMono.glyphs:19
- The '◂' glyph has been removed from the glyph list; confirm if this removal is intentional. If this symbol is still needed for proper rendering, please restore it.
"/.notdef ▂▃▄▅▆▇█▀▔▏▎▍▌▋▊▉▐▕▖▗▘▙▚▛▜▝▞▟░▒▓●○◦◊■□▲▶▼◀▴▾◂╦╗╔═╩╝╚║╬╣╠╥╖╓┰┒┧┎┟╁┯┑┩┍┡╇╤╕╒╍╏╻┳┓┏━╸╾┉┋╺┅┇╹┻┛╿┗┃╋┫┣╅┭┵┽┲┺╊╃╮╭╯╰╌╎╳╲╱╷┬┐┌─╴╼┈┊╶┄┆╵╽┴┘└│┼┤├╆┮┶┾┱┹╉╄╨╜╙╀┸┦┚┞┖╈┷┪┙┢┕╧╛╘╫╢╟╂┨┠┿┥┝╪╡╞",
The 100 is for the prior glyphs that were added. The 200 is for this change of font metrics and spacing.
caidanw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes updates to the
fonts/ServerMono.glyphsfile to adjust font metric values for improved vertical alignment and spacing. As well as switching to the more intentional nameObliqueinstead ofSlanted(was causing some problems with certain tools).Font metric adjustments:
hheaAscender,typoAscender, andwinAscentvalues were increased from750to900to provide more vertical space above the baseline.hheaDescender,typoDescender, andwinDescentvalues were adjusted from-250to-200to reduce the vertical space below the baseline.Visuals
Before:
After:
It's a subtle change, but it does make a big impact on legibility and getting it aligned with the rest of the design. This also fixes the visual bug when patching with Nerd Fonts, where the icons and the letters were not aligned correctly.