-
Notifications
You must be signed in to change notification settings - Fork 475
Make demo pages meet lighthouse a11y best practices #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1455 +/- ##
=======================================
Coverage 69.48% 69.48%
=======================================
Files 62 62
Lines 5306 5306
Branches 1149 1149
=======================================
Hits 3687 3687
Misses 1585 1585
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the accessibility of BookReader demo pages to meet Lighthouse a11y best practices and align with archive.org standards. The changes address two key accessibility issues: missing language declarations and restrictions on user zoom capability.
Key changes:
- Added
lang="en"attribute to all HTML pages for proper language declaration - Removed
maximum-scale=1.0, user-scalable=nofrom viewport meta tags to allow users to zoom pages - Fixed malformed HTML in demo-preview-pages.html and wrapped checkboxes in labels in demo-internetarchive.html
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| index.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/viewmode-cycle.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/view_mode.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/toggle_controls.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/immersion-mode.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/immersion-1up.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-vendor-fullscreen.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-simple.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-preview-pages.html | Added lang attribute, removed zoom restrictions, and fixed malformed viewport meta tag |
| BookReaderDemo/demo-multiple.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-internetarchive.html | Added lang attribute, removed zoom restrictions, and wrapped checkboxes in labels for improved accessibility |
| BookReaderDemo/demo-iiif.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-fullscreen.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-fullscreen-mobile.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-embed.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-embed-iframe-src.html | Added lang attribute and removed zoom restrictions from viewport |
| BookReaderDemo/demo-advanced.html | Added lang attribute and removed zoom restrictions from viewport |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Pass failing lighthouse accessibility checks on the demo pages html. Also makes them more in sync with archive.org.