Skip to content

Fix Translate plugin crash in preview mode #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himanshu4812 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Translate plugin crash in preview mode #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/plugins/translate/plugin.translate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ export class TranslatePlugin extends BookReaderPlugin {
}
/** @type {HTMLElement} textLayerElement */
const textLayerElement = page.querySelector('.BRtextLayer');
if (!textLayerElement) {
console.warn("Translate unavailable: no text layer (preview mode?)");
return;
}
// Should use native DOM element.style method instead of $().css method, specific issue with rendering / style calculation in Chrome
$(pageTranslationLayer).css({
"width": textLayerElement.style.width,
Expand Down Expand Up @@ -307,6 +311,12 @@ export class TranslatePlugin extends BookReaderPlugin {
}

handleToggleTranslation = async () => {
const hasTextLayer = document.querySelector('.BRtextLayer');
if (!hasTextLayer) {
alert("Please borrow the book to use translation.");
return;
}

this.userToggleTranslate = !this.userToggleTranslate;
this.translationManager.active = this.userToggleTranslate;

Expand Down