Skip to content

Fix: prevent infinite loading on identical language translation #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reckz69 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: prevent infinite loading on identical language translation #1499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions src/plugins/translate/plugin.translate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,21 +307,27 @@ export class TranslatePlugin extends BookReaderPlugin {
}

handleToggleTranslation = async () => {
// Prevent translating if source and target languages are the same
if (this.langFromCode === this.langToCode) {
alert("Source and target languages cannot be the same.");
return; // Stop here — do NOT enable translation
}

this.userToggleTranslate = !this.userToggleTranslate;
this.translationManager.active = this.userToggleTranslate;

this._render();

if (!this.userToggleTranslate) {
this.clearAllTranslations();
this.br.trigger('translationDisabled', { });
this.br.trigger('translationDisabled', {});
this.textSelectionManager.detach();
} else {
this.br.trigger('translationEnabled', { });
this.br.trigger('translationEnabled', {});
this.translateActivePageContainerElements();
this.textSelectionManager.attach();
}
}

};
/**
* Update translation side menu
*/
Expand Down Expand Up @@ -481,21 +487,19 @@ export class BrTranslatePanel extends LitElement {

_toggleTranslation(event) {
const toggleTranslateEvent = new CustomEvent('toggleTranslation', {
detail: {value: event.target.value},
detail: {},
bubbles: true,
composed:true,
composed: true,
});
this.userTranslationActive = !this.userTranslationActive;
this.dispatchEvent(toggleTranslateEvent);
}


// TODO: Hardcoded warning message for now but should add more statuses
_statusWarning() {
if (this.detectedFromLang == this.detectedToLang) {
return "Translate To language is the same as the Source language";
}
return "";
}
_statusWarning() {
return "";
}


_languageModelStatus() {
if (this.userTranslationActive) {
Expand Down