Skip to content

Fix Issue #1474: Initialize br.book Before Plugins to Prevent Startup Errors #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manikyarathore wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Issue #1474: Initialize br.book Before Plugins to Prevent Startup Errors #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0442620
Fixed Issue #1305
manikyarathore Dec 17, 2025
710e930
Merge branch 'master' into master
manikyarathore Feb 2, 2026
aac7a96
Fix plugin initialization order when reduceSet is invalid
manikyarathore Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions src/BookReader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,17 @@ BookReader.prototype.setup = function(options) {
/** @deprecated */
this.bookPath = options.bookPath;

if (options.reduceSet && !NAMED_REDUCE_SETS[options.reduceSet]) {
console.warn(
`Invalid reduceSet "${options.reduceSet}". Falling back to default.`
);
}
this.reduceSet =NAMED_REDUCE_SETS[options.reduceSet] || NAMED_REDUCE_SETS[DEFAULT_OPTIONS.reduceSet];
this.pageProgression = options.pageProgression;
this.protected = options.protected;
this.data = options.data;
this.book = new BookModel(this);

// Construct the usual plugins first to get type hints
this.plugins = {
archiveAnalytics: BookReader.PLUGINS.archiveAnalytics ? new BookReader.PLUGINS.archiveAnalytics(this) : null,
Expand Down Expand Up @@ -247,12 +258,6 @@ BookReader.prototype.setup = function(options) {
this.defaults = options.defaults;
this.padding = options.padding;

this.reduceSet = NAMED_REDUCE_SETS[options.reduceSet];
if (!this.reduceSet) {
console.warn(`Invalid reduceSet ${options.reduceSet}. Ignoring.`);
this.reduceSet = NAMED_REDUCE_SETS[DEFAULT_OPTIONS.reduceSet];
}

/** @type {number}
* can be 1 or 2 or 3 based on the display mode const value
*/
Expand Down Expand Up @@ -305,19 +310,10 @@ BookReader.prototype.setup = function(options) {
this.enableExperimentalControls = options.enableExperimentalControls;
this.el = options.el;

this.pageProgression = options.pageProgression;
this.protected = options.protected;
this.getEmbedCode = options.getEmbedCode;
this.popup = null;

// Assign the data methods
this.data = options.data;

/** @type {{[name: string]: JQuery}} */
this.refs = {};

/** The book being displayed in BookReader*/
this.book = new BookModel(this);

if (options.getNumLeafs) this.book.getNumLeafs = options.getNumLeafs.bind(this);
if (options.getPageWidth) this.book.getPageWidth = options.getPageWidth.bind(this);
Expand All @@ -329,6 +325,11 @@ BookReader.prototype.setup = function(options) {
if (options.getSpreadIndices) this.book.getSpreadIndices = options.getSpreadIndices.bind(this);
if (options.leafNumToIndex) this.book.leafNumToIndex = options.leafNumToIndex.bind(this);


/** @type {{[name: string]: JQuery}} */
this.refs = {};


/**
* @private Components are 'subchunks' of bookreader functionality, usually UI related
* They should be relatively decoupled from each other/bookreader.
Expand Down
2 changes: 1 addition & 1 deletion src/BookReader/Mode2UpLit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,4 +785,4 @@ export class LeafEdges extends LitElement {
mouseEventToPageIndex(e) {
return Math.floor(this.leftIndex + (e.offsetX / this.offsetWidth) * (this.rightIndex - this.leftIndex + 1));
}
}
}