Skip to content

Prototype: Add elements to BR #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jbuckner wants to merge 5 commits into
base: master
Choose a base branch
from
+238 −11
Draft

Prototype: Add elements to BR #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16209e5
Test adding elements to BR
jbuckner Feb 3, 2026
d83006f
Add svg-inline-loader
jbuckner Feb 3, 2026
b0a4d25
Add svg mock for jest tests
jbuckner Feb 4, 2026
f6a5b07
Use webpack's built-in asset loader for svgs
jbuckner Feb 4, 2026
0d77b37
Externalize svgs
jbuckner Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 224 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"private": false,
"dependencies": {
"@internetarchive/bergamot-translator": "^0.4.9-ia.1",
"@internetarchive/elements": "0.2.1-webdev-8151.0",
"@internetarchive/ia-activity-indicator": "^0.0.4",
"@internetarchive/ia-item-navigator": "2.2.2",
"@internetarchive/icon-bookmark": "^1.4.0",
Expand Down Expand Up @@ -94,6 +95,7 @@
"node_modules/(?!(sinon|lit-html|lit-element|lit|@lit|@lit-labs|@internetarchive|@open-wc)/)"
],
"moduleNameMapper": {
"\\.svg$": "<rootDir>/tests/jest/mocks/svg.js",
"^@/(.*)$": "<rootDir>/$1"
},
"setupFiles": [
Expand Down
3 changes: 3 additions & 0 deletions src/BookReader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ import { ImageCache } from './BookReader/ImageCache.js';
import { PageContainer } from './BookReader/PageContainer.js';
import { NAMED_REDUCE_SETS } from './BookReader/ReduceSet.js';

import '@internetarchive/elements/ia-status-indicator/ia-status-indicator';
import '@internetarchive/elements/ia-combo-box/ia-combo-box';

/**
* BookReader
* @param {Partial<BookReaderOptions>} overrides
Expand Down
4 changes: 4 additions & 0 deletions tests/jest/mocks/svg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/**
* Mock for SVG imports in Jest tests.
*/
export class SVGMock {}
6 changes: 5 additions & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ const shared = {
{
test: /\.js$/,
exclude: /node_modules[/\\](?!(lit-element|lit-html|lit|@lit)[/\\]).*/,
loader: "babel-loader",
loader: 'babel-loader',
},
{
test: /\.svg/,
type: 'asset/resource',
},
],
},
Expand Down