Skip to content

Fix: Add null checks and logging when deleting URIs from BdbMultipleWorkQueues (#690)#693

Merged
ato merged 2 commits intointernetarchive:masterfrom
manikyarathore:master_m2
Nov 26, 2025
Merged

Fix: Add null checks and logging when deleting URIs from BdbMultipleWorkQueues (#690)#693
ato merged 2 commits intointernetarchive:masterfrom
manikyarathore:master_m2

Conversation

@manikyarathore
Copy link
Copy Markdown
Contributor

This PR fixes issue #690 by adding proper null handling and improved logging inside BdbMultipleWorkQueues.delete().

Changes include:

  • Added check for null CrawlURI
  • Added check for null holderKey
  • Type validation for holderKey to ensure it is a DatabaseEntry
  • Added warning logs for all invalid states
  • Prevents NullPointerExceptions during delete()

This improves stability of the frontier when corrupted or partially persisted CrawlURIs appear in the queue.

@ato ato linked an issue Nov 26, 2025 that may be closed by this pull request
@ato ato merged commit da0fb46 into internetarchive:master Nov 26, 2025
3 checks passed
@ato
Copy link
Copy Markdown
Collaborator

ato commented Nov 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate and log on deleting URIs from BdB database

2 participants