Fix Service Worker push subscription race condition#1463
Open
OlegPhenomenon wants to merge 4 commits intomasterfrom
Open
Fix Service Worker push subscription race condition#1463OlegPhenomenon wants to merge 4 commits intomasterfrom
OlegPhenomenon wants to merge 4 commits intomasterfrom
Conversation
- Use navigator.serviceWorker.ready to ensure SW is active before subscribing - Remove duplicate SW registration in setupPushNotifications() - Add error handling for push subscription failures - Add null check for webpush modal element Fixes "no active Service Worker" and "invalid applicationServerKey" errors
Modal now shows before requesting browser permission. Permission is requested only when user clicks Accept button. Added proper error handling for Service Worker SSL issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "no active Service Worker" and "invalid applicationServerKey" errors #1451