Conversation
Collaborator
Author
|
Regarding SHA2 key exchange: TLS 1.2 still supports signature algorithms here that do not meet the new requirements. So, we need to keep the check, but modify it from "you must support SHA2" to "you must not support any SHA1 or MD5". In TLS 1.3, only SHA2 is supported for this purpose. |
mxsasha
force-pushed
the
sslyze
branch
3 times, most recently
from
June 24, 2025 13:55
98ace1a to
ac3edcc
Compare
mxsasha
force-pushed
the
ncsc2025
branch
7 times, most recently
from
July 29, 2025 11:01
faeba8d to
3b59db8
Compare
mxsasha
force-pushed
the
ncsc2025
branch
3 times, most recently
from
August 4, 2025 14:16
e46af94 to
63c8ff9
Compare
mxsasha
force-pushed
the
ncsc2025
branch
4 times, most recently
from
August 12, 2025 14:38
ad38aec to
8b418e4
Compare
This was referenced Sep 1, 2025
mxsasha
force-pushed
the
ncsc2025
branch
2 times, most recently
from
February 26, 2026 18:02
2f90a17 to
0bf7fd8
Compare
mxsasha
force-pushed
the
sslyze
branch
2 times, most recently
from
February 26, 2026 18:08
d7e715c to
7eed098
Compare
mxsasha
force-pushed
the
ncsc2025
branch
3 times, most recently
from
February 26, 2026 19:15
fcfd9bf to
703e50d
Compare
mxsasha
force-pushed
the
sslyze
branch
3 times, most recently
from
March 10, 2026 13:24
63bf3ab to
f582737
Compare
mxsasha
force-pushed
the
ncsc2025
branch
7 times, most recently
from
March 10, 2026 15:02
e113e7e to
3301948
Compare
Some key changes: * FFDHE2024 -> insufficient, others -> phase out * Remove ECDHE/DHE min key size - this is superfluous * Update SHA2 key exchange check to new requirements (must reject SHA1 and older, sha224 to phase out). * Update cert requirements, including RSA phase out for 2048 * Add RSA-PKCS check * Update client initiated renegotiation limits, incl DB changes for 3 states now * Add support for EMS test * Check all non-root certs for sighash/key size/curve. * Update content to 98c5150 from TLS branch
This is a bit wonky, but it's fine, it's only for the dev4 test period
This was removed from NCSC TLS update.
We decided not to test this scenario after considering the suites at each level. Only bad>(sufficient+good) is considered.
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for resumption (3.4.3)no new test, this is covered by TLS version checkInteresting data point: the old SHA2 key exchange check had a bug in the sslyze branch, which we did not notice in comparisons probably because it never fails.
Weird results
Discuss:
To consider
display 'banner' for old tests at TLS test (category, or preferably at each sub test detail level): an explanation that the test verdict (text) and content are no longer in sync / even correct? The new explanation for the new rules are shown: advise retest.Content
See content PR