Skip to content

Fix #2023 - Add score impact for EMS #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxsasha merged 1 commit into from
Apr 14, 2026
+16 −2
Merged

Fix #2023 - Add score impact for EMS #2025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions checks/categories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,11 +1541,14 @@ def __init__(self):
label="detail web tls extended-master-secret label",
explanation="detail web tls extended-master-secret exp",
tech_string="detail web tls extended-master-secret tech table",
worst_status=scoring.STATUS_INFO,
worst_status=STATUS_INFO,
full_score=scoring.TLS_EXTENDED_MASTER_SECRET_GOOD,
model_score_field="extended_master_secret_score",
)

def was_tested(self):
self.worst_status = STATUS_FAIL

def save_result(self, status: TLSExtendedMasterSecretStatus):
handlers = {
TLSExtendedMasterSecretStatus.supported: self.result_good,
Expand All @@ -1556,21 +1559,25 @@ def save_result(self, status: TLSExtendedMasterSecretStatus):
return handlers[status]()

def result_good(self):
self.was_tested()
self._status(STATUS_SUCCESS)
self.verdict = "detail web tls extended-master-secret verdict good"
self.tech_data = "detail tech data yes"

def result_bad(self):
self.was_tested()
self._status(STATUS_FAIL)
self.verdict = "detail web tls extended-master-secret verdict bad"
self.tech_data = "detail tech data no"

def result_unknown(self):
self.was_tested()
self._status(STATUS_NOT_TESTED)
self.verdict = "detail web tls extended-master-secret verdict unknown"
self.tech_data = "detail tech data not-tested"

def result_na_no_tls_1_2(self):
self.was_tested()
self._status(STATUS_SUCCESS)
self.verdict = "detail web tls extended-master-secret verdict na-no-tls-1-2"
self.tech_data = "detail tech data not-applicable"
Expand Down Expand Up @@ -2175,11 +2182,14 @@ def __init__(self):
label="detail mail tls extended-master-secret label",
explanation="detail mail tls extended-master-secret exp",
tech_string="detail mail tls extended-master-secret tech table",
worst_status=scoring.STATUS_INFO,
worst_status=STATUS_INFO,
full_score=scoring.TLS_EXTENDED_MASTER_SECRET_GOOD,
model_score_field="extended_master_secret_score",
)

def was_tested(self):
self.worst_status = STATUS_FAIL

def save_result(self, status: TLSExtendedMasterSecretStatus):
handlers = {
TLSExtendedMasterSecretStatus.supported: self.result_good,
Expand All @@ -2190,21 +2200,25 @@ def save_result(self, status: TLSExtendedMasterSecretStatus):
return handlers[status]()

def result_good(self):
self.was_tested()
self._status(STATUS_SUCCESS)
self.verdict = "detail mail tls extended-master-secret verdict good"
self.tech_data = "detail tech data yes"

def result_bad(self):
self.was_tested()
self._status(STATUS_FAIL)
self.verdict = "detail mail tls extended-master-secret verdict bad"
self.tech_data = "detail tech data no"

def result_unknown(self):
self.was_tested()
self._status(STATUS_NOT_TESTED)
self.verdict = "detail mail tls extended-master-secret verdict unknown"
self.tech_data = "detail tech data not-tested"

def result_na_no_tls_1_2(self):
self.was_tested()
self._status(STATUS_SUCCESS)
self.verdict = "detail mail tls extended-master-secret verdict na-no-tls-1-2"
self.tech_data = "detail tech data not-applicable"
Expand Down
Loading