suggested changes from code review

Author: daimor

package.json

@@ -519,8 +519,8 @@
             },
             "server": {
               "type": "string",
-              "pattern": "^[A-Za-z0-9-._~]+$",
-              "markdownDescription": "Server defined in `intersystems.servers`"
+              "pattern": "^[a-z0-9-._~]+$",
+              "markdownDescription": "Server defined in `#intersystems.servers#`"
             },
             "host": {
               "type": "string",

src/api/index.ts

@@ -455,7 +455,7 @@ export class AtelierAPI {
   }
 
   // v2+
-  public getmacrollist(docname: string, includes: string[]): Promise<Atelier.Response> {
+  public getmacrolist(docname: string, includes: string[]): Promise<Atelier.Response> {
     return this.request(2, "POST", `${this.ns}/action/getmacrolist`, {
       docname,
       includes,

src/commands/serverActions.ts

@@ -13,7 +13,7 @@ export async function serverActions(): Promise<void> {
   const actions = [];
   if (!api.externalServer) {
     actions.push({
-      detail: "Enable/Disable current connection",
+      detail: (active ? "Disable" : "Enable") + " current connection",
       id: "toggleConnection",
       label: "Toggle Connection",
     });
@@ -82,7 +82,7 @@ export async function serverActions(): Promise<void> {
   if (workspaceState.get(workspaceFolder + ":docker", false)) {
     actions.push({
       id: "openDockerTerminal",
-      label: "Open terminal in docker",
+      label: "Open Terminal in Docker",
       detail: "Use docker-compose to start session inside configured service",
     });
   }

src/providers/ObjectScriptCompletionItemProvider.ts

@@ -100,7 +100,7 @@ export class ObjectScriptCompletionItemProvider implements vscode.CompletionItem
       const file = currentFile();
       const api = new AtelierAPI();
       return api
-        .getmacrollist(file.name, [])
+        .getmacrolist(file.name, [])
         .then((data) => data.result.content.macros)
         .then((list) => list.filter((el) => el.toLowerCase().startsWith(macro)))
         .then((list) => list.map((el) => "$$$" + el))