Skip to content

Implement Show Plan CodeLens #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

isc-bsaviano
Copy link
Contributor

This PR adds a new Show Plan CodeLens. The CodeLens will appear above %SQLQuery Class Query definitions and Embedded SQL queries if the query can generate an execution plan, and a connection to IRIS 2024.1+ is active. When the CodeLens is clicked, the query text, select mode and imported packages are extracted from the document and sent to the server. The returned plan is then rendered as HTML in a webview. Only one Show Plan webview can be visible at any time. Include files are captured, and support for passing them to the server-side SQL plan code will come in a future IRIS release.
Screenshot 2025-03-10 at 8 23 41 AM

@gjsjohnmurray
Copy link
Contributor

@isc-bsaviano shall I delay looking at this until you have resolved the issues flagged by CI? And then is it time to ship new releases of this an Server Manager?

@isc-bsaviano
Copy link
Contributor Author

I didn't notice the CI failures, I will take a look at those now. Yes, this is the last change that I had planned for 3.0.0. I am out of the office this Thursday, Friday, and the following Monday so I will open the release preparation PRs for both extensions after I return.

@gjsjohnmurray
Copy link
Contributor

FYI I shall be OOO after 3/20, returning 4/2.

@isc-bsaviano
Copy link
Contributor Author

Thanks for letting me know. March 18th and 19th are the only days we'd both be available in case we need a quick patch version. I am fine with releasing one of those two days, or waiting until 4/2. @isc-rsingh Any thoughts?

@isc-rsingh
Copy link
Member

isc-rsingh commented Mar 10, 2025

My preference is to wait until 4/2 to release.

@isc-bsaviano
Copy link
Contributor Author

4/2 is fine with me.

@isc-bsaviano isc-bsaviano merged commit aa4a038 into intersystems-community:master Mar 10, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the sql-plan branch March 10, 2025 14:59
isc-bsaviano added a commit to isc-bsaviano/vscode-objectscript that referenced this pull request Mar 18, 2025
@isc-bsaviano isc-bsaviano mentioned this pull request Mar 18, 2025
isc-bsaviano added a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants