Fix issue where Undo after a save deletes the file being edited
#1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-bsaviano
changed the title
isc-bsaviano
changed the title
Undo after a save deletes the file being edited
gjsjohnmurray
previously approved these changes
Apr 3, 2025
Contributor
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
LGTM but not tested
gjsjohnmurray
previously approved these changes
Apr 3, 2025
isc-bsaviano
dismissed stale reviews from isc-rsingh and gjsjohnmurray
via
94d4a5d
gjsjohnmurray
approved these changes
Apr 4, 2025
|
Hi, do we have a delivery timeframe for this fix? Our developers are reporting the loss of significant bodies of work. |
Contributor
Author
|
Today |
Contributor
Author
|
@mathewrimmingtoncds Version 3.0.1 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1522. The issue is that we "recreate" the file when loading changes from the compiler, so Undo undoes this "creation" and deletes the file. I fixed the issue by going back to the
fs.writeFile()API. This issue is pretty bad, so I'm considering bumping version as part of the PR and doing the 3.0.1 release immediately.