Skip to content

Export namespace warning check should be case-insensitive #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Export namespace warning check should be case-insensitive #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/commands/export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,12 @@ export async function exportAll(): Promise<any> {

export async function exportExplorerItems(nodes: NodeBase[]): Promise<any> {
const node = nodes[0];
const origNamespace = config("conn", node.workspaceFolder).ns;
if (origNamespace !== node.namespace) {
const nodeNs = node.namespace.toUpperCase();
const origNamespace = config("conn", node.workspaceFolder).ns?.toUpperCase();
if (origNamespace?.toUpperCase() != node.namespace.toUpperCase()) {
const answer = await vscode.window.showWarningMessage(
`
You are about to export from namespace ${node.namespace}.
You are about to export from namespace ${nodeNs}.

Future edits to the file(s) in your local workspace will be saved and compiled in the primary namespace of your workspace root, ${origNamespace}, not the namespace from which you originally exported.

Expand All @@ -272,9 +273,8 @@ Would you like to continue?`,
return;
}
}
const { workspaceFolder, namespace } = node;
return Promise.all(nodes.map((node) => node.getItems4Export())).then((items) => {
return exportList(items.flat(), workspaceFolder, namespace).then(() => explorerProvider.refresh());
return exportList(items.flat(), node.workspaceFolder, nodeNs).then(() => explorerProvider.refresh());
});
}

Expand Down