Skip to content

Handle errors when fetching server-side source control menu options fails #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Handle errors when fetching server-side source control menu options fails #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/commands/studio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,13 +424,13 @@ export class StudioActions {

const query = "select * from %Atelier_v1_Utils.Extension_GetMenus(?,?,?)";
const parameters = [menuType, this.name, selectedText];
const noun = sourceControl ? "source control action" : "command";

return this.api
.actionQuery(query, parameters)
.then((data) => data.result.content)
.then((menus) => this.prepareMenuItems(menus, sourceControl))
.then((menuItems) => {
const noun = sourceControl ? "source control action" : "command";
const suffix = this.name ? ` on ${this.name}` : "";
if (menuItems.length == 0) {
vscode.window.showInformationMessage(`There are no server-side ${noun}s to execute${suffix}.`, "Dismiss");
Expand All @@ -441,7 +441,10 @@ export class StudioActions {
title: `Pick a server-side ${noun} to execute${suffix}`,
});
})
.then((action) => this.userAction(action));
.then((action) => this.userAction(action))
.catch((error) => {
handleError(error, `Failed to get the server-side ${noun} menu options.`);
});
}

public fireOtherStudioAction(action: OtherStudioAction, userAction?: UserAction): void {
Expand Down