Skip to content

Don't append extra trailing newlines when saving server-side web app files #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Don't append extra trailing newlines when saving server-side web app files #1648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/providers/FileSystemProvider/FileSystemProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,15 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
content: base64EncodeContent(contentBuffer),
enc: true,
};
if (
csp &&
!putContent.enc &&
putContent.content.length > 1 &&
putContent.content[putContent.content.length - 1] == ""
) {
// Avoid appending a blank line on every save, which would cause a web app file to grow each time
putContent.content.pop();
}
// By the time we get here VS Code's built-in conflict resolution mechanism will already have interacted with the user.
// Therefore, it's safe to ignore any conflicts.
return api
Expand Down