Fix CodeUnit dependencies around UpdateComplexity

CHANGELOG.md

@@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [4.0.1] - 2024-08-09
 
+### Fixed 
 - #45: Fixed Python line 0 tracking for 2024.2 
+- #46: Fix for bug caused by UpdateComplexity calling GetCurrentByName unnecessarily and causing dependency issues
 
 ## [4.0.0] - 2024-08-01
 

cls/TestCoverage/Data/CodeUnit.cls

@@ -44,7 +44,9 @@ Property LineIsPython As array Of %Boolean;
 /// Set to true if this class/routine is generated
 Property Generated As %Boolean [ InitialExpression = 0 ];
 
-/// 
+/// If the CodeUnit has changed since we last updated it, used to see if we need to call UpdateComplexity
+Property OutdatedComplexity As %Boolean [ InitialExpression = 1 ];
+
 /// Methods, branches, etc. within this unit of code.
 Relationship SubUnits As TestCoverage.Data.CodeSubUnit [ Cardinality = children, Inverse = Parent ];
 
@@ -87,6 +89,9 @@ ClassMethod GetCurrentByName(pInternalName As %String, pSourceNamespace As %Stri
 			If (tUpdatedHash '= tKnownHash) {
 				//Clear out old data and flag the need for an update.
 				Set tNeedsUpdate = 1
+				If $IsObject($Get(tMapToUnit)) {
+					set tMapToUnit.OutdatedComplexity = 1 
+				}
 				&sql(delete from TestCoverage_Data.CodeUnitMap where ToHash = :tKnownHash)
 				If (SQLCODE < 0) {
 					Throw ##class(%Exception.SQL).CreateFromSQLCODE(SQLCODE,%msg)
@@ -521,9 +526,10 @@ Method UpdateSourceMap(pSourceNamespace As %String, ByRef pCache) As %Status
 			}
 		}
 
-		// Update cyclomatic complexity for methods in the linked class
+		// Update cyclomatic complexity for methods in the linked class if we don't already have the newest version
 		Set tClass = $Order(tCodeUnits("CLS",""),1,tClassCodeUnit)
-		If $IsObject($Get(tClassCodeUnit)) {
+		If ($IsObject($Get(tClassCodeUnit)) && (tClassCodeUnit.OutdatedComplexity)){
+			set tClassCodeUnit.OutdatedComplexity = 0
 			$$$ThrowOnError(tClassCodeUnit.UpdateComplexity())
 		}
 	} Catch e {
@@ -690,6 +696,9 @@ Storage Default
 <Value name="5">
 <Value>Generated</Value>
 </Value>
+<Value name="6">
+<Value>OutdatedComplexity</Value>
+</Value>
 </Data>
 <Data name="LineIsPython">
 <Attribute>LineIsPython</Attribute>

cls/TestCoverage/Manager.cls

@@ -683,12 +683,11 @@ ClassMethod OnBeforeAllTests(manager As TestCoverage.Manager, dir As %String, By
 			Set tSC = manager.UpdateCoverageTargetsForTestDirectory(dir)
 			$$$ThrowOnError(tSC)
 		}
-
+		if (manager.ListenerManager) {
+			set tObj = {"message": "Starting tests"}
+			Do manager.ListenerManager.BroadCastToAll(tObj)
+		}
 		If (manager.CoverageDetail = 0) {
-			if (manager.ListenerManager) {
-				set tObj = {"message": "Starting tests"}
-				Do manager.ListenerManager.BroadCastToAll(tObj)
-			}
 			Set tSC = manager.StartCoverageTracking()
 			$$$ThrowOnError(tSC)
 		}