Skip to content

Fix pause monitor #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Fix pause monitor #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57b115a
fix: when we resume the monitor after pausing, start the python monit…
isc-cge Aug 15, 2024
bbaa048
docs: changelog
isc-cge Aug 15, 2024
2ecde00
fix: kill PyMonitorResults global on Clear(), shouldn't change anythi…
isc-cge Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [4.0.1] - 2024-08-09
## [4.0.1] - Unreleased

### Fixed
- #45: Fixed Python line 0 tracking for 2024.2
- #46: Fix for bug caused by UpdateComplexity calling GetCurrentByName unnecessarily and causing dependency issues
- #47: Fixed mapping issue caused by empty lines at top of Python method not showing up in compiled Python
- #48: When the Line-By-Line Monitor resumes after pausing, resume the Python tracer too

## [4.0.0] - 2024-08-01

Expand Down
3 changes: 2 additions & 1 deletion cls/TestCoverage/Utils.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Include %occInclude
Include (%occInclude, TestCoverage)

IncludeGenerator TestCoverage

Expand All @@ -18,6 +18,7 @@ ClassMethod Clear() As %Status
Set tClasses("TestCoverage.Data.CodeUnit") = ""
Set tClasses("TestCoverage.Data.Coverage") = ""
Set tClasses("TestCoverage.Data.Run") = ""
kill $$$PyMonitorResults

Set tClass = ""
For {
Expand Down
1 change: 1 addition & 0 deletions cls/TestCoverage/Utils/LineByLineMonitor.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ Method StartWithScope(pRoutineList As %List, pPyClasses As %List, pMetricList As
$$$ThrowOnError(tSC)
If ..Paused {
$$$ThrowOnError(..Resume())
Do ..PyStartWithScope(pPyClasses)
}
}
} Catch e {
Expand Down
Loading