Skip to content

Preview load to determine if class is production no longer overwrites class #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

isc-pbarton
Copy link
Collaborator

Fixes #830

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.00%. Comparing base (8aa09fd) to head (8e99a1a).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Production.cls 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #834   +/-   ##
=======================================
  Coverage   49.00%   49.00%           
=======================================
  Files          24       24           
  Lines        3269     3269           
=======================================
  Hits         1602     1602           
  Misses       1667     1667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton
Copy link
Collaborator Author

Testing steps:
In a namespace configured with a Git repository, create a new class pbarton.test830

Class pbarton.test830 Extends Ens.BusinessProcess
{

Method OnRequest(request As %Library.Persistent, Output response As %RegisteredObject) As %Status
{
}

Storage Default
{
<Type>%Storage.Persistent</Type>
}

}

Save and compile the class. It should fail to compile.
Change the method spec to this:

Method OnRequest(request As %Library.Persistent, Output response As %Library.Persistent) As %Status

Save and compile the class. It should compile successfully.

Previous to this fix, saving the class would reset the method spec to the previous broken state.

@isc-pbarton isc-pbarton merged commit 368d46e into main Aug 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class with compile issue cannot be fixed.
3 participants