Skip to content

Installer now works on IRIS versions with IRISSECURITY #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Conversation

isc-pbarton
Copy link
Collaborator

fixes #770

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.03%. Comparing base (368d46e) to head (14c66a3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   49.00%   49.03%   +0.03%     
==========================================
  Files          24       24              
  Lines        3269     3271       +2     
==========================================
+ Hits         1602     1604       +2     
  Misses       1667     1667              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

do ##class(%SQL.Statement).%ExecDirect(statement,sql).%Display()
kill props
set props("GroupById") = "%ISCMgtPortal"
set st = ##class(Security.Applications).Modify("/isc/studio/usertemplates",.props)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this syntax backwards-compatible to pre-2025.2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, based on documentation it should be backwards compatible since before IRIS, and I tested on IRIS 2023.2 as well.

Copy link
Collaborator

@isc-npetroce isc-npetroce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@isc-pbarton isc-pbarton merged commit 83c88c6 into main Aug 15, 2025
2 checks passed
@isc-pbarton isc-pbarton deleted the fix-770 branch August 15, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing on 2025.2
3 participants