-
Notifications
You must be signed in to change notification settings - Fork 24
Package Manager should support creation of a lock file #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…l to not lose all current progress
|
Test coverage notes: Modules required for testing:
Module A (0 deps) Edge cases:
Module G. Includes dependencies for (to be created as well): |
isc-kiyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isc-jlechtne my first round of comments is up! Will review the tests once the comments are addressed.
isc-eneil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isc-jlechtne Left another round of comments!
A couple of suggestions that won't stop me from upvoting because they're about code readability rather than functioning:
- For maintainability and since they are not meaningful, I would not number these test method names
- For readability, I'd name the module parameters meaningfully as well
9bc48b0 to
b837b48
Compare
isc-kiyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isc-jlechtne looks good overall! Few comments
resolves #961