Skip to content

fix(shell): isolate execution context for exec/cos commands #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc-dchui merged 6 commits into from
Jan 16, 2026
Merged

fix(shell): isolate execution context for exec/cos commands #996

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
906b731
fix(shell): isolate execution context for exec/cos commands
AshokThangavel Dec 19, 2025
461d965
docs: add details to changelog
AshokThangavel Dec 19, 2025
b19f0eb
Merge branch 'main' into fix/exec-context-isolation
AshokThangavel Jan 7, 2026
8d1e474
fix: updated the ExecuteCOS method
AshokThangavel Jan 7, 2026
65b56c2
Merge branch 'main' into fix/exec-context-isolation
AshokThangavel Jan 9, 2026
3697db9
Merge branch 'main' into fix/exec-context-isolation
isc-dchui Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- #950: Added support for listing installed Python packages using `list -python`, `list -py` and `list-installed -python`
- #822: The CPF resource processor now supports system expressions and macros in CPF merge files
- #578 Added functionality to record and display IPM history of install, uninstall, load, and update
- #996:Ensure COS commands execute in exec under a dedicated, isolated context

### Changed
- #316: All parameters, except developer mode, included with a `load`, `install` or `update` command will be propagated to dependencies
Expand Down
14 changes: 12 additions & 2 deletions src/cls/IPM/Main.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,8 +980,7 @@ ClassMethod ShellInternal(
} elseif (tCommandInfo = "load") {
do ..Load(.tCommandInfo)
} elseif (tCommandInfo = "exec") {
write !
xecute tCommandInfo("parameters","expression")
do ..ExecuteCOS(.tCommandInfo)
} elseif (tCommandInfo = "install") {
do ..Install(.tCommandInfo)
} elseif (tCommandInfo = "reinstall") {
Expand Down Expand Up @@ -2213,6 +2212,17 @@ ClassMethod Load(
$$$ThrowOnError(log.Finalize($$$OK, devMode))
}

ClassMethod ExecuteCOS(ByRef tCommandInfo)
{
set namespace = $namespace
Copy link
Collaborator

@isc-dchui isc-dchui Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new $namespace line before this

Copy link
Contributor Author

@AshokThangavel AshokThangavel Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Added the new $namespace and removed the set namespace = $namespace

try {
write !
xecute tCommandInfo("parameters","expression")
} catch ex {
Copy link
Collaborator

@isc-dchui isc-dchui Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just throw the error and let the exception handling of ShellInternal() handle it.

Copy link
Contributor Author

@AshokThangavel AshokThangavel Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added the $$$ThrowOnError inside catch block.

Copy link
Collaborator

@isc-dchui isc-dchui Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity's sake, I don't think we need this extra try/catch block in this method. The error should be propagatable up the call stack, so essentially just

ClassMethod ExecuteCOS(ByRef tCommandInfo)
{
new $namespace
write !
xecute commandInfo("parameters","expression")
}

Also minor nit: remove the t- prefixes.

Copy link
Contributor Author

@AshokThangavel AshokThangavel Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing. I have updated the method to use the minimalist approach as suggested. I removed the try/catch block and the t- prefixes from the variables.

}
set $namespace = namespace
}

ClassMethod LoadInternal(
ByRef pCommandInfo,
pLog As %IPM.General.AbstractHistory) [ Internal ]
Expand Down