[store] Use a common interface for scd/rid/aux stores#1405
Merged
mickmis merged 1 commit intointeruss:masterfrom Mar 31, 2026
Merged
[store] Use a common interface for scd/rid/aux stores#1405mickmis merged 1 commit intointeruss:masterfrom
mickmis merged 1 commit intointeruss:masterfrom
Conversation
mickmis
approved these changes
Mar 31, 2026
Contributor
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
Simplify a bit further by deleting the 3 type Store and directly use dssstore.Store[repos.Repository] where Store is used?
LGTM modulo the above
Contributor
Author
Yes, plan is to clean up globally at a later stage, with the BaseStore that is coming soon, so that one is probably going to be gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #1403
Normalize store interfaces into a common one.
Add context to transactions for aux/rid.
Fix tests accordingly.
More normalization to come in future PR on that interface.