[datastore] Stop crons on ctx's cancels, cancel ctx when error occur during RunHTTPServer#1410
Open
the-glu wants to merge 3 commits intointeruss:masterfrom
Open
[datastore] Stop crons on ctx's cancels, cancel ctx when error occur during RunHTTPServer#1410the-glu wants to merge 3 commits intointeruss:masterfrom
the-glu wants to merge 3 commits intointeruss:masterfrom
Conversation
the-glu
force-pushed
the
cancel_crons_on_close
branch
from
14cdca7 to
b7f7a5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow #1409
Cron where partially manually canceled in original code in one case. That case has been removed in #1409 .
This now fix the situation by canceling cron on context's cancel and by canceling context in all error return path of
RunHTTPServer, ensuring they are canceled correctly.(e.g. scd's cron was never canceled in original code)