Skip to content

Add more overrides for rpc bind address and server broadcast address #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barroco merged 2 commits into from
Aug 3, 2025
Merged

Add more overrides for rpc bind address and server broadcast address #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f36887e
Add more overrides
the-glu May 27, 2025
f355443
Merge branch 'master' into fix_overrides
the-glu Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stable/yugabyte/templates/master-gflags-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ stringData:
--max_log_size=256
--undefok=num_cpus,enable_ysql
--use_node_hostname_for_local_tserver=true
--rpc_bind_addresses={{ include "yugabyte.rpc_bind_address" $serviceValues }}
--server_broadcast_addresses={{ include "yugabyte.server_broadcast_address" $serviceValues }}
--rpc_bind_addresses={{ $root.Values.master.rpcBindAddress | default (include "yugabyte.rpc_bind_address" $serviceValues) }}
--server_broadcast_addresses={{ $root.Values.master.serverBroadcastAddress | default (include "yugabyte.server_broadcast_address" $serviceValues) }}
--webserver_interface={{ include "yugabyte.webserver_interface" $serviceValues }}
{{- range $flag, $override := $root.Values.gflags.master }}
--{{ $flag }}={{ $override }}
Expand Down
2 changes: 1 addition & 1 deletion stable/yugabyte/templates/tserver-gflags-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ stringData:
--undefok=num_cpus,enable_ysql
--use_node_hostname_for_local_tserver=true
--cql_proxy_bind_address={{ include "yugabyte.cql_proxy_bind_address" $serviceValues }}
--rpc_bind_addresses={{ include "yugabyte.rpc_bind_address" $serviceValues }}
--rpc_bind_addresses={{ $root.Values.tserver.rpcBindAddress | default (include "yugabyte.rpc_bind_address" $serviceValues) }}
--server_broadcast_addresses={{ $root.Values.tserver.serverBroadcastAddress | default (include "yugabyte.server_broadcast_address" $serviceValues) }}
--webserver_interface={{ include "yugabyte.webserver_interface" $serviceValues }}
{{- range $flag, $override := $root.Values.gflags.tserver }}
Expand Down
13 changes: 13 additions & 0 deletions stable/yugabyte/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,15 @@ master:
# fieldPath: status.hostIP
extraEnv: []

## Sets the --server_broadcast_addresses flag on the Master pods, no
## preflight checks are done for this address. You might need to add
## `use_private_ip: cloud` to the gflags.master and gflags.tserver.
serverBroadcastAddress: ""

## Sets the --rpc_bind_addresses flag on the Master pods, no
## preflight checks are done for this address.
rpcBindAddress: ""

# secretEnv variables are used to expose secrets data as env variables in the master pod.
# TODO Add namespace also to support copying secrets from other namespace.
# secretEnv:
Expand Down Expand Up @@ -669,6 +678,10 @@ tserver:
## `use_private_ip: cloud` to the gflags.master and gflags.tserver.
serverBroadcastAddress: ""

## Sets the --rpc_bind_addresses flag on the TServer, no
## preflight checks are done for this address.
rpcBindAddress: ""

## Extra volumes
## extraVolumesMounts are mandatory for each extraVolumes.
## Ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#volume-v1-core
Expand Down