add ruff and pre-commit#50
Merged
ioannistsanaktsidis merged 2 commits intoinveniosoftware-contrib:masterfrom Oct 14, 2025
Merged
add ruff and pre-commit#50ioannistsanaktsidis merged 2 commits intoinveniosoftware-contrib:masterfrom
ioannistsanaktsidis merged 2 commits intoinveniosoftware-contrib:masterfrom
Conversation
PascalEgn
force-pushed
the
add-ruff-and-pre-commit
branch
2 times, most recently
from
63a3b92 to
b5fb63a
Compare
PascalEgn
force-pushed
the
add-ruff-and-pre-commit
branch
2 times, most recently
from
1c06016 to
b36e1eb
Compare
ioannistsanaktsidis
requested changes
Oct 14, 2025
Contributor
ioannistsanaktsidis
left a comment
ioannistsanaktsidis
left a comment
There was a problem hiding this comment.
Some questions/comments. Note PR is dropping unicode (u''), which is the first step of dropping py2 support
invenio_classifier/api.py
Outdated
| line_nb, word_nb | ||
| ) | ||
| ) | ||
| logger.info("Remote file has %d lines and %d words.".format()) |
Contributor
There was a problem hiding this comment.
why remove the line_nb ?
Contributor
Author
There was a problem hiding this comment.
Ironically the line never worked and always outputted Remote file has %d lines and %d words., thats why ruff removed the line_nb variable (as its not used anywhere else...)
But okay the line should be fixed now and works in py2 and py3
PascalEgn
force-pushed
the
add-ruff-and-pre-commit
branch
from
b36e1eb to
9856f4c
Compare
ioannistsanaktsidis
merged commit 10f2307
into
inveniosoftware-contrib:master
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: cern-sis/issues-inspire#1080