Skip to content

feat(install): use uv#882

Merged
ntarocco merged 1 commit intoinveniosoftware:masterfrom
ntarocco:feat/use-uv
Oct 30, 2025
Merged

feat(install): use uv#882
ntarocco merged 1 commit intoinveniosoftware:masterfrom
ntarocco:feat/use-uv

Conversation

@ntarocco
Copy link
Copy Markdown
Contributor

No description provided.

@ntarocco
Copy link
Copy Markdown
Contributor Author

To be ported to the production branch too.

@utnapischtim
Copy link
Copy Markdown
Contributor

why do you want to add the uv.lock file?

@ntarocco
Copy link
Copy Markdown
Contributor Author

why do you want to add the uv.lock file?

For this repo is not very interesting indeed, I can remove it if you prefer.

@Samk13
Copy link
Copy Markdown
Member

Samk13 commented Oct 29, 2025

why do you want to add the uv.lock file?

if you delete uv.lock, the uv sync --locked in the CI cannot work because there's no lock to check. We need to remove the flag as well in that case.

@ntarocco
Copy link
Copy Markdown
Contributor Author

why do you want to add the uv.lock file?

if you delete uv.lock, the uv sync --locked in the CI cannot work because there's no lock to check. We need to remove the flag as well in that case.

Right, however we can decide if it is really needed for this case. Normally you want a lock file when you need to install in your env the same exact dependencies. For the doc, is it not that crucial, and I doubt that locally people will update it when committing the new change.
I would be in favor of removing it for the above considerations. WDYT? @utnapischtim @Samk13

Copy link
Copy Markdown
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that works. (I've also been using uv for it locally for a long time but via uv pip install -r requirements.txt). Thanks!

"mkdocs>=1.6.1",
"mkdocs-glightbox>=0.5.2",
"mkdocs-material>=9.6.22",
]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed strange to me to need a pyproject.toml at first (I am used to uv run --no-project ... and this isn't really a package), but if we do want to use uv sync and skip the step of manually creating a virtualenv, it makes sense.

(we'll see about that python version in the future hahaha)

@ntarocco ntarocco merged commit 08c8aca into inveniosoftware:master Oct 30, 2025
1 check passed
@ntarocco ntarocco deleted the feat/use-uv branch October 30, 2025 14:08
@mfenner
Copy link
Copy Markdown
Contributor

mfenner commented Oct 30, 2025

When running this, I get these messages:

INFO    -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
             - maintenance/architecture/faq.md
             - maintenance/internals/extensions.md
             - maintenance/internals/frontend.md
             - maintenance/internals/naming.md
             - operate/customize/requests.md
             - releases/vNext/upgrade-vNext.md
             - releases/vNext/version-vNext.md
INFO    -  Doc file 'releases/vNext/upgrade-vNext.md' contains a link '#opensearch-version', but there is no such anchor on this page.

I assume this is intentional and not related to the migration to uv.

@fenekku
Copy link
Copy Markdown
Collaborator

fenekku commented Oct 30, 2025

I don't think it's intentional but it is not related to uv :). Just a link to fix in that page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants